Feature/spawn with interfacer #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## experimental/jlnav_plus_shuds_asktell #1464 +/- ##
=========================================================================
+ Coverage 78.75% 78.76% +0.01%
=========================================================================
Files 81 81
Lines 8076 8072 -4
Branches 1422 1196 -226
=========================================================================
- Hits 6360 6358 -2
- Misses 1502 1504 +2
+ Partials 214 210 -4 ☔ View full report in Codecov by Sentry. |
jlnav
approved these changes
Nov 14, 2024
shuds13
merged commit e8b7052
into
experimental/jlnav_plus_shuds_asktell
14 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch makes the Optimas/APOSMM example work with spawn, as well as fork.
I have removed the extra comm created with the multiprocessing server queues and instead am using the QCommProcess
directly. I have not tried with a thread as yet, but it works with a process.
Spawn still failed due to a threadlock on the executor
commattribute (which is added in worker.py). This would be the wrong comm anyway when passing to the APOSMM process. Removing this enables spawn to work.Some attention needs to be paid to passing the executor, to ensure this works both when actually used in the gen and when no executor exists.